Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please hide -ms-reveal #8390

Closed
wuchtig opened this issue Nov 12, 2017 · 3 comments · Fixed by #8439
Closed

Please hide -ms-reveal #8390

wuchtig opened this issue Nov 12, 2017 · 3 comments · Fixed by #8439
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions

Comments

@wuchtig
Copy link

wuchtig commented Nov 12, 2017 •
edited
Loading

Bug, feature request, or proposal:

Please hide -ms-reveal.

What is the expected behavior?

Password field shouldn't have 2 reveal Buttons.

What is the current behavior?

password

What are the steps to reproduce?

Look at Material Demo Site

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

MSEdge: 41.16299.15.0
Material: 5.0.0-rc0-3ca801a
@jelbourn jelbourn added discussion feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions labels Nov 14, 2017
@jelbourn
Copy link
Member

@mmalerba do you think we should bake this into the input?

@mmalerba
Copy link
Contributor

@jelbourn We do already hide Edge's clear button. I'm not really sure if we should be hiding them though. I could see that maybe Edge users have come to expect them. But at the same time I think a lot of developers might not consider this case when implementing their own reveal / clear buttons. I guess I slightly lean toward just hiding them all for x-browser consistency.

@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue and removed discussion labels Nov 14, 2017
@crisbeto crisbeto self-assigned this Nov 14, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 14, 2017
@crisbeto
fix(input): remove native IE reveal icon
369e6ea 
Removes the password reveal icon, that IE adds by default on inputs, for cross-browser consistency.

Fixes angular#8390.
@crisbeto crisbeto mentioned this issue Nov 14, 2017
Merged
jelbourn pushed a commit that referenced this issue Nov 18, 2017
@crisbeto @jelbourn
fix(input): remove native IE reveal icon
3c3df54 
Removes the password reveal icon, that IE adds by default on inputs, for cross-browser consistency.

Fixes #8390.
jelbourn pushed a commit that referenced this issue Nov 20, 2017
@crisbeto @jelbourn
fix(input): remove native IE reveal icon (#8439)
47055a7 
Removes the password reveal icon, that IE adds by default on inputs, for cross-browser consistency.

Fixes #8390.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input): remove native IE reveal icon crisbeto/material2
4 participants
@jelbourn @wuchtig @crisbeto @mmalerba