fix(tabs): detach tab portal when tab hides from view #8486
Conversation
googlebot
added
the
cla: yes
src/lib/tabs/tab-body.ts
Outdated
| if (this._centeringSub && !this._centeringSub.closed) { | ||
| this._centeringSub.unsubscribe(); | ||
| } | ||
| this._centeringSub.unsubscribe(); |
There was a problem hiding this comment.
It probably still need to check whether _centeringSub exists because some people, in their unit tests, destroy a component before calling detectChanges
| fixture.whenStable().then(() => { | ||
| expect(fixture.nativeElement.textContent).not.toContain('Pizza, fries'); | ||
| expect(fixture.nativeElement.textContent).toContain('Peanuts'); | ||
| }); |
There was a problem hiding this comment.
Expand this to change the tab and re-assert the the others are gone?
jelbourn
added
pr: lgtm
action: merge
|
Marking as P1 since this fixes a regression |
|
@josephperrott Thanks for this pull request, but shouldn't the tab portal not be detached until the animation is done (after centering rather than before)? The section on "Navigational transitions" in the Material Design Guidelines specifies that in a sibling to sibling transition
Since this merge, it seems that the "moves off-screen" part has been effectively removed. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.