fix(icon): server-side error when registering icons #8492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
Any ETA when this will make it into a release? This is blocking our migration to Universal, so it would be good to know if I just wait another day or look for a different solution. |
|
This is a major change due to the constructor being altered, seeing breaking tests internally due to subclasses breaking |
andrewseguin
added
target: major
|
Constructor change could be avoided by not using the injected document |
crisbeto
force-pushed
the
6787/icon-registry-ssr
branch
from
ec0df1a
to
ae07b22
Compare
|
Reworked it to avoid the breaking change. Switching back to patch release. |
crisbeto
added
target: patch
Fixes an error that is thrown by the `IconRegistry` when registering icons on the server side. Fixes angular#6787.
crisbeto
force-pushed
the
6787/icon-registry-ssr
branch
from
ae07b22
to
3cac816
Compare
andrewseguin
added
the
presubmit failures
jelbourn
removed
the
presubmit failures
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
Fixes an error that is thrown by the `IconRegistry` when registering icons on the server side. Fixes angular#6787.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
Fixes an error that is thrown by the `IconRegistry` when registering icons on the server side. Fixes angular#6787.
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
Fixes an error that is thrown by the `IconRegistry` when registering icons on the server side. Fixes #6787.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
Fixes an error that is thrown by the `IconRegistry` when registering icons on the server side. Fixes #6787.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error that is thrown by the
IconRegistrywhen registering icons on the server side.Fixes #6787.