Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): not resetting completely when overlay is detached externally #8515

Merged
merged 1 commit into from
Dec 13, 2017
Merged

fix(autocomplete): not resetting completely when overlay is detached externally #8515

merged 1 commit into from
Dec 13, 2017

Conversation

crisbeto
Copy link
Member

Fixes the autocomplete not closing correctly when its OverlayRef is detached externally (e.g. by a scroll strategy).

@crisbeto
fix(autocomplete): not resetting completely when overlay is detached …
9258e6f 
…externally

Fixes the autocomplete not closing correctly when its `OverlayRef` is detached externally (e.g. by a scroll strategy).
@crisbeto crisbeto requested a review from kara as a code owner November 17, 2017 17:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 17, 2017
jelbourn
jelbourn approved these changes Nov 28, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 28, 2017
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
@andrewseguin andrewseguin merged commit a8cd033 into angular:master Dec 13, 2017
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Dec 19, 2017
@crisbeto @andrewseguin
fix(autocomplete): not resetting completely when overlay is detached …
8e14343 
…externally (angular#8515)

Fixes the autocomplete not closing correctly when its `OverlayRef` is detached externally (e.g. by a scroll strategy).
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin