fix(autocomplete): not implementing setDisabledState from ControlValueAccessor #8746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
8735/autocomplete-disabled-state
branch
from
71a471c
to
ebcea44
Compare
|
Also needs rebase |
…eAccessor Fixes plain inputs (without a `matInput`) that has a `formControl` and an autocomplete attached not being disabled via `FormControl.disable`. The issue was due to the `MatAutocompleteTrigger` not implementing the `setDisableState`. The current implementation is in line with the approach in the `DefaultValueAccessor`. Fixes angular#8735.
crisbeto
force-pushed
the
8735/autocomplete-disabled-state
branch
from
ebcea44
to
93bda3c
Compare
crisbeto
added
action: merge
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Dec 19, 2017
…eAccessor (angular#8746) Fixes plain inputs (without a `matInput`) that has a `formControl` and an autocomplete attached not being disabled via `FormControl.disable`. The issue was due to the `MatAutocompleteTrigger` not implementing the `setDisableState`. The current implementation is in line with the approach in the `DefaultValueAccessor`. Fixes angular#8735.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes plain inputs (without a
matInput) that have aformControland an autocomplete attached not being disabled viaFormControl.disable. The issue was due to theMatAutocompleteTriggernot implementing thesetDisableState. The current implementation is in line with the approach in theDefaultValueAccessor.Fixes #8735.