fix(dialog): improved type safety in dialog ref result #8766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
8760/dialog-ref-typing
branch
from
8dab3e6
to
13709dd
Compare
jelbourn
added
pr: lgtm
action: merge
crisbeto
added
target: minor
src/lib/dialog/dialog-ref.ts
Outdated
| @@ -101,14 +101,14 @@ export class MatDialogRef<T> { | |||
| /** | |||
| * Gets an observable that is notified when the dialog is finished closing. | |||
| */ | |||
| afterClosed(): Observable<any> { | |||
| afterClosed(): Observable<R> { | |||
There was a problem hiding this comment.
Should the return type here be Observable<R | undefined> since the dialogResult parameter in the close method is optional?
There was a problem hiding this comment.
Good point, I'm not sure why TS didn't complain about it.
Adds an extra generic param to the `MatDialogRef` that allows consumers to type the result that is passed to `close`, as well as the value in the `beforeClosed` and `afterClosed` observables. Fixes angular#8760.
crisbeto
force-pushed
the
8760/dialog-ref-typing
branch
from
13709dd
to
e23b154
Compare
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Dec 19, 2017
Adds an extra generic param to the `MatDialogRef` that allows consumers to type the result that is passed to `close`, as well as the value in the `beforeClosed` and `afterClosed` observables. Fixes angular#8760.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra generic param to the
MatDialogRefthat allows consumers to type the result that is passed toclose, as well as the value in thebeforeClosedandafterClosedobservables.Fixes #8760.