Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paginator): coerce string values #8946

Merged
merged 1 commit into from
Dec 13, 2017
Merged

fix(paginator): coerce string values #8946

merged 1 commit into from
Dec 13, 2017

Conversation

rafaelss95
Copy link
Contributor

Coerces any string values that are passed to pageIndex, length, pageSize to numbers.

Also, I added the coercion to pageSizeOptions to allow people to pass a string array, e.g: ['1', '5', ...].

Fixes #8624.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 12, 2017
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 12, 2017
@andrewseguin andrewseguin merged commit 0388202 into angular:master Dec 13, 2017
@rafaelss95 rafaelss95 deleted the fix-paginator branch December 15, 2017 00:39
@mhosman
Copy link

mhosman commented Jan 2, 2018

This fix is available in a new version???

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pagination] Example passes string for pageSize, breaking getRangeLabel
4 participants