fix(button): hover styles being applied to disabled buttons #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| // Use the same visual treatment for hover as for focus. | ||
| @include md-button-focus(); | ||
| [md-button], [md-icon-button] { | ||
| &:not([disabled]):hover { |
There was a problem hiding this comment.
I'm hesitant to get so specific with the rule. Can it be done such that the disabled style is defined after the hover style with the same specificity as to override it?
There was a problem hiding this comment.
Done, although I think that this adds a little to the selector length, but reduces specificity. It seemed strange that the :after is used to add the background.
crisbeto
force-pushed
the
866/disabled-button-hover
branch
2 times, most recently
from
5b6c2cf to
2945e83
Compare
|
@crisbeto LGTM if you can rebase |
Fixes the button hover styles being applied, even if a button is disabled. Fixes angular#866.
crisbeto
force-pushed
the
866/disabled-button-hover
branch
from
2945e83 to
b557e10
Compare
|
Sorry @jelbourn, I was away last week. It's rebased now. |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Aug 14, 2016
) Fixes the button hover styles being applied, even if a button is disabled. Fixes angular#866.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the button hover styles being applied, even if a button is disabled.
Fixes #866.