Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: too strict peer dependency of angular #9355

Merged
merged 1 commit into from
Jan 12, 2018
Merged

fix: too strict peer dependency of angular #9355

merged 1 commit into from
Jan 12, 2018

Conversation

devversion
Copy link
Member

  • Right now the peerDependency of Angular will be the one from the package.json. This means that upcoming minor versions of Angular cause peer dependency warnings within Yarn or NPM.
  • Adds a info to the publish task, because it can be easy to forget about the version in the config.

Fixes #9328

@devversion
fix: too strict peer dependency of angular
0561bbb 
* Right now the `peerDependency` of Angular will be the one from the `package.json`. This means that upcoming minor versions of Angular cause peer dependency warnings within Yarn or NPM.

Fixes angular#9328
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 12, 2018
jelbourn
jelbourn approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 12, 2018
@andrewseguin andrewseguin merged commit 7187670 into angular:master Jan 12, 2018
@devversion devversion deleted the fix/peer-dependency-version branch January 12, 2018 17:28
@CaerusKaru CaerusKaru mentioned this pull request Jan 12, 2018
Closed
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this pull request Jan 12, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
b884ab9 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this pull request Jan 13, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
a65efcd 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this pull request Jan 13, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
ea334b6 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this pull request Jan 13, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
687b06f 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this pull request Jan 14, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
4702a5d 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
* Bring package build patterns in line with angular/material2
* Enable strictNullChecks and refactor as necessary
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this pull request Jan 14, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
9185ce7 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
* Bring package build patterns in line with angular/material2
* Enable strictNullChecks and refactor as necessary
CaerusKaru added a commit to CaerusKaru/flex-layout that referenced this pull request Jan 14, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
7207499 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
* Bring package build patterns in line with angular/material2
* Enable strictNullChecks and refactor as necessary
@CaerusKaru CaerusKaru mentioned this pull request Jan 15, 2018
Closed
CaerusKaru added a commit to angular/flex-layout that referenced this pull request Jan 15, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
c760db3 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
* Bring package build patterns in line with angular/material2
* Enable strictNullChecks and refactor as necessary
CaerusKaru added a commit to angular/flex-layout that referenced this pull request Jan 16, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
4abb127 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
* Bring package build patterns in line with angular/material2
* Enable strictNullChecks and refactor as necessary
CaerusKaru added a commit to angular/flex-layout that referenced this pull request Jan 16, 2018
@CaerusKaru
chore: update to Angular v5.2 and update peer dep requirements
57cc365 
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Update travis to node 8 and npm latest
* Bring package build patterns in line with angular/material2
* Enable strictNullChecks and refactor as necessary
ThomasBurleson pushed a commit to angular/flex-layout that referenced this pull request Jan 16, 2018
@CaerusKaru @ThomasBurleson
chore(versions): update to Angular v5.2 and update peer dep requirements
061083d 
* Update travis to node 8 and npm latest
* Update to Angular v5.2 and TypeScript v2.6
* Update build config to conform with angular/components#9355
* Bring package build patterns in line with angular/material2
* Enable strictNullChecks and refactor as necessary

Closes #560.
Fixes #566, #559.
andrewseguin pushed a commit that referenced this pull request Jan 17, 2018
@devversion @andrewseguin
fix: too strict peer dependency of angular (#9355)
aac5508 
* Right now the `peerDependency` of Angular will be the one from the `package.json`. This means that upcoming minor versions of Angular cause peer dependency warnings within Yarn or NPM.

Fixes #9328
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Peer dependency version of Angular is too specific
4 participants
@devversion @jelbourn @googlebot @andrewseguin