Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

TypeScript 2.9 support #1104

Closed
mprobst opened this issue Jun 22, 2018 · 3 comments
Closed

TypeScript 2.9 support #1104

mprobst opened this issue Jun 22, 2018 · 3 comments

Comments

@mprobst
Copy link
Contributor

mprobst commented Jun 22, 2018

Zone JS doesn't compile with TypeScript 2.9:

v0_8_16/lib/browser/define-property.ts:24:70 - error TS2469: The '+' operator cannot be applied to type 'symbol'.

24       throw new TypeError('Cannot assign to read only property \'' + prop + '\' of ' + obj);
                                                                        ~~~~
v0_8_16/lib/browser/define-property.ts:28:37 - error TS2345: Argument of type 'string | number | symbol' is not assignable to parameter of type 'string'.
  Type 'number' is not assignable to type 'string'.

28       desc = rewriteDescriptor(obj, prop, desc);
                                       ~~~~
v0_8_16/lib/browser/define-property.ts:30:36 - error TS2345: Argument of type 'string | number | symbol' is not assignable to parameter of type 'string'.
  Type 'number' is not assignable to type 'string'.

30     return _tryDefineProperty(obj, prop, desc, originalConfigurableFlag);
                                      ~~~~
@mprobst
Copy link
Contributor Author

mprobst commented Jun 22, 2018

(note: this is using v0.8.16, but it looks as if the compile errors are still current)

@JiaLiPassion
Copy link
Collaborator

I did some modification in other PR, I will check that PR can pass TS 2.9 or not.

@JiaLiPassion
Copy link
Collaborator

This has already been fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants