Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot be used as a meson subproject (wrap) #115

Closed
dcbaker opened this issue Mar 27, 2017 · 2 comments
Closed

Cannot be used as a meson subproject (wrap) #115

dcbaker opened this issue Mar 27, 2017 · 2 comments

Comments

@dcbaker
Copy link
Contributor

dcbaker commented Mar 27, 2017

meson.source_root() will always be the toplevel source root, so if libepoxy is used as a wrap the generation of epoxy_headers will fail since it will look in the for include/epoxy in the parent project, not in epoxy itself.

@ebassi
Copy link
Collaborator

ebassi commented Mar 28, 2017

Indeed, we use meson.source_root() twice:

  • once to find the gen_dispatch.py script, to work around a Meson bug that was already fixed a couple of releases ago
  • once to construct a full path to the headers in order to generate appropriate dependencies, as we refer to those files from different directories

Both should go away regardless.

@ebassi
Copy link
Collaborator

ebassi commented Mar 28, 2017

@dcbaker I've opened a PR that should fix the issue; testing is appreciated.

@ebassi ebassi closed this as completed in 2dafa2f Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants