SyntaxError: invalid syntax during "make"

[felibb]

Hi,

I am trying to compile libepoxy on AWS Linux, and I get this error during "make":

/bin/mkdir -p ../include/epoxy
  GEN      gl_generated_dispatch.c
  File "./gen_dispatch.py", line 67
    'glBegin',
             ^
SyntaxError: invalid syntax
make[2]: *** [gl_generated_dispatch.c] Error 1
make[2]: Leaving directory `/opt/libepoxy-1.2/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/libepoxy-1.2'
make: *** [all] Error 2

autogen.sh ran without errors. Any help is appreciated.

[anholt]

It looks like maybe you've got a python error, except that it looks truncated somehow? It doesn't make any sense to me.

[nwnk]

It's not truncated. The bug is that's not legal syntax in python 2.6.

[nwnk]

Something like this gets it to build on RHEL6.7, though obviously can't be merged as-is since it drops the wgl and gles bits.

diff -up libepoxy-1.2/src/gen_dispatch.py.jx libepoxy-1.2/src/gen_dispatch.py
--- libepoxy-1.2/src/gen_dispatch.py.jx 2015-10-28 11:23:44.441741032 -0400
+++ libepoxy-1.2/src/gen_dispatch.py    2015-10-28 11:24:03.604898390 -0400
@@ -63,14 +63,7 @@ class GLFunction(object):
         # These are functions with hand-written wrapper code in
         # dispatch_common.c.  Their dispatch entries are replaced with
         # non-public symbols with a "_unwrapped" suffix.
-        wrapped_functions = {
-            'glBegin',
-            'glEnd',
-            'wglMakeCurrent',
-            'wglMakeContextCurrentEXT',
-            'wglMakeContextCurrentARB',
-            'wglMakeAssociatedContextCurrentAMD',
-        }
+        wrapped_functions = [ 'glBegin', 'glEnd' ]

         if name in wrapped_functions:
             self.wrapped_name = name + '_unwrapped'
@@ -204,7 +197,7 @@ class Generator(object):

     def parse_typedefs(self, reg):
         for t in reg.findall('types/type'):
-            if 'name' in t.attrib and t.attrib['name'] not in {'GLhandleARB'}:
+            if 'name' in t.attrib and t.attrib['name'] not in ['GLhandleARB']:
                 continue

             # The gles1/gles2-specific types are redundant
@@ -401,7 +394,7 @@ class Generator(object):
                 condition = 'epoxy_conservative_has_wgl_extension("{0}")'.format(extname)
                 loader = 'wglGetProcAddress({0})'
                 self.process_require_statements(extension, condition, loader, human_name)
-            if {'gl', 'gles1', 'gles2'}.intersection(apis):
+            if 'gl' in apis:
                 human_name = 'GL extension \\"{0}\\"'.format(extname)
                 condition = 'epoxy_conservative_has_gl_extension("{0}")'.format(extname)
                 loader = 'epoxy_get_proc_address({0})'

[ebassi]

Is this still an issue, or can we close it?

[ebassi]

RHEL 6 won't be rebased, and RHEL 7 has Python 2.7, which means gen_dispatch.py does not need to be changed.