Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible documentation update: EXPO_USE_METRO_WORKSPACE_ROOT=1 to build #109

Closed
tbloomfi opened this issue May 13, 2024 · 5 comments · Fixed by #139
Closed

Possible documentation update: EXPO_USE_METRO_WORKSPACE_ROOT=1 to build #109

tbloomfi opened this issue May 13, 2024 · 5 comments · Fixed by #139

Comments

@tbloomfi
Copy link

I was getting a 404 error for the expo-router and was only able to run the app after exporting EXPO_USE_METRO_WORKSPACE_ROOT=1 as per the monorepo instructions.

Should this be added to the build instructions or added automatically in the package.json file?

@TimoGlastra
Copy link
Member

Hmm I've been able to build it fine without that command. What command are you adding this to? And from which directory are you running the app?

@timbl-ont
Copy link

Just tested again with a fresh clone of the main branch with the same result - via Android simulator.

Node Version: v18.20.2

I followed the Readme:

yarn
cd apps/expo
yarn prebuild
yarn android

Screen shot:
Screenshot 2024-06-04 at 11 42 31 AM

The same steps after running "export EXPO_USE_METRO_WORKSPACE_ROOT=1" in the shell fixed the error, launching the wallet. This setting is from here: "https://docs.expo.dev/guides/monorepos" - the note on Expo Router.

@TimoGlastra
Copy link
Member

Okay thanks for looking into it! @berendsliedrecht something you can add with the restructure soon?

@berendsliedrecht
Copy link
Member

Yes, I'll pay attention to it!

@TimoGlastra
Copy link
Member

I ran into the same issue -- have fixed it locally and will open a PR. Thanks for reporting @timbl-ont

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants