From 9756c82b01ea45a94895d5fe4bcc2ecbe5d99f78 Mon Sep 17 00:00:00 2001
From: Felix Kastner <felix.kastner@uni-hamburg.de>
Date: Tue, 5 Dec 2023 07:43:58 +0100
Subject: [PATCH] fix some errors reported by JET.jl

---
 Project.toml     | 2 +-
 src/algebraic.jl | 4 ++--
 src/promote.jl   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Project.toml b/Project.toml
index 31a55ad..bf38885 100644
--- a/Project.toml
+++ b/Project.toml
@@ -1,7 +1,7 @@
 name = "AlgebraicNumbers"
 uuid = "e86d093a-a386-599e-b7c7-df0420c8bcba"
 authors = ["Al Nejati", "Felix Kastner"]
-version = "0.1.9"
+version = "0.1.10"
 
 [deps]
 Nemo = "2edaba10-b0f1-5616-af89-8c11ac63239a"
diff --git a/src/algebraic.jl b/src/algebraic.jl
index aa6fbd6..b420cd4 100644
--- a/src/algebraic.jl
+++ b/src/algebraic.jl
@@ -137,7 +137,7 @@ end
 function ==(an1::AlgebraicNumber,an2::AlgebraicNumber)
 	cf1 = an1.coeff
 	cf2 = an2.coeff
-	(cf1/cf1[end])==(cf2/cf2[end]) || return false
+	(cf1./cf1[end])==(cf2./cf2[end]) || return false
 	prec1 = calc_precision(an1.coeff, an1.apprx)
 	prec2 = calc_precision(an2.coeff, an2.apprx)
 	return abs(an1.apprx-an2.apprx)<min(prec1,prec2)
@@ -185,7 +185,7 @@ end
 
 # partially simplify a polynomial b
 # eliminating repeated factors
-reduce_repeated_factors(p::Nemo.ZZPolyRingElem) = prod(keys(Nemo.factor(p)))
+reduce_repeated_factors(p::Nemo.ZZPolyRingElem) = prod([p for (p,e) in Nemo.factor(p)]; init=one(p))
 
 # multiplication
 function *(an1::AlgebraicNumber,an2::AlgebraicNumber)
diff --git a/src/promote.jl b/src/promote.jl
index 47df346..1766fd2 100644
--- a/src/promote.jl
+++ b/src/promote.jl
@@ -20,6 +20,6 @@ function convert(::Type{Int64},an::AlgebraicNumber)
 	if length(c)==2 && abs(c[2])==1
 		return convert(Int64, -c[1]*c[2])
 	else
-		throw(InexactError())
+		throw(InexactError(:convert, Int64, an))
 	end
 end