Update to work with desktop 2.1.54 code #11644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jun 20, 2022
This was referenced Jun 20, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jun 21, 2022
If a non-Robolectric test happens to run first in a process, subsequent Robolectric tests in that process will fail. ankidroid#11644 (comment)
Merged
7 tasks
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jun 25, 2022
If a non-Robolectric test happens to run first in a process, subsequent Robolectric tests in that process will fail. ankidroid#11644 (comment)
dae
force-pushed
the
new-anki2
branch
2 times, most recently
from
0384f0c
to
5f05618
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dae
force-pushed
the
new-anki2
branch
2 times, most recently
from
a0379c5
to
129dfee
Compare
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jun 25, 2022
If a non-Robolectric test happens to run first in a process, subsequent Robolectric tests in that process will fail. ankidroid#11644 (comment)
|
Wow, what an odyssey, but all in a good way. @dae, thank you 🤜 🤛 - really cool to be on up to date anki code and have a such a solid base for future work |
This was referenced Jun 29, 2022
|
YESS!!! Thank you! |
|
Thanks for all the hard work on pushing this through guys. I'm preparing a follow-up PR that will address some of the posted issues. |
|
I'm headed out for some family travels end of this week through mid-August so I won't be able to push nearly that hard (if at all?) for a while but I'll try to keep an eye out and will hit any green github web UI buttons that look good to hit :-) |
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jun 30, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jun 30, 2022
| * Construct a search string from the provided search nodes. For example: | ||
| * */ | ||
| /* | ||
| import anki.search.searchNode |
There was a problem hiding this comment.
Thanks a lot for this clear documentation. Clearly useful, not only to understand ow to call the function, but also to find out where to search for the different values, given that they are not directly in our codebase so can't be find by a standard search
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 6, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 6, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 6, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 6, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 11, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 11, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 16, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 16, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 18, 2022
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Jul 18, 2022
mikehardy
pushed a commit
that referenced
this pull request
Jul 22, 2022
mikehardy
pushed a commit
that referenced
this pull request
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ankidroid/Anki-Android-Backend#202
Due to the removal and change of a few backend methods, syncing, importing
and the card templates screen will not work when the schema16 setting is
active (actually schema18 now). To get them working again, those code
paths will need to switch to the backend implementations.
A few notes:
mode, so the extra code dealing with downgrades & "can downgrade" reporting
can be stripped.
unit tests were attempting to write the entire collection config to accomplish
this, which is no longer supported.
disabling a few failed tests when running with the new schema
(eg notetype updating).
Integrates, and thus closes #11579 and closes #11581
Closes #11559