Kotlin migration ModelTest #11665
Merged
Kotlin migration ModelTest #11665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prince-kushwaha
force-pushed
the
kotlint_migration_modelTest
branch
4 times, most recently
from
2200b4e
to
4bbadbb
Compare
|
@david-allison how i fix below unit test error if i not made change in UpgradeGesturesToControlsTest.kt |
Prince-kushwaha
force-pushed
the
kotlint_migration_modelTest
branch
from
4bbadbb
to
d92d652
Compare
|
@Prince-kushwaha that failure is a flaky test - it's actually our most common flake at the moment, pretty irritating - hopefully either someone has time to fix it soon or I'll have to disable it in CI #11091 (comment) |
lukstbit
requested changes
Jul 7, 2022
lukstbit
added
the
Needs Author Reply
Prince-kushwaha
force-pushed
the
kotlint_migration_modelTest
branch
from
d92d652
to
e3908b1
Compare
lukstbit
requested changes
Jul 10, 2022
Prince-kushwaha
force-pushed
the
kotlint_migration_modelTest
branch
from
e3908b1
to
9dc3243
Compare
lukstbit
approved these changes
Jul 10, 2022
lukstbit
added
Needs Second Approval
|
Oh no, @Prince-kushwaha sorry about this - it appears to have taken a conflict before I had any time to work through the second review queue and get things merged. I'm really sorry about that. Do you have time to fix the conflict? |
mikehardy
added
the
Needs Author Reply
Prince-kushwaha
force-pushed
the
kotlint_migration_modelTest
branch
3 times, most recently
from
d3e255a
to
5e2e53f
Compare
Prince-kushwaha
force-pushed
the
kotlint_migration_modelTest
branch
from
5e2e53f
to
de3b685
Compare
|
@mikehardy i fixed the conflict |
Arthur-Milchior
approved these changes
Jul 31, 2022
github-actions
bot
removed
the
Needs Author Reply
github-actions
bot
removed
the
Needs Second Approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Purpose / Description
Kotlin Migration of ModelTest