-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] migrated AnkiStatsTaskHandler.createReviewSummaryStatistics() to suspend function #11667
Merged
ShridharGoel
merged 2 commits into
ankidroid:main
from
thedroiddiv:AsyncTask_To_Coroutines
Jun 22, 2022
Merged
[GSoC] migrated AnkiStatsTaskHandler.createReviewSummaryStatistics() to suspend function #11667
ShridharGoel
merged 2 commits into
ankidroid:main
from
thedroiddiv:AsyncTask_To_Coroutines
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkiDroid/src/main/java/com/ichi2/anki/stats/AnkiStatsTaskHandler.kt
Outdated
Show resolved
Hide resolved
thedroiddiv
force-pushed
the
AsyncTask_To_Coroutines
branch
from
June 21, 2022 15:59
8610238
to
0e29502
Compare
lukstbit
requested changes
Jun 22, 2022
AnkiDroid/src/main/java/com/ichi2/anki/stats/AnkiStatsTaskHandler.kt
Outdated
Show resolved
Hide resolved
lukstbit
added
Review High Priority
Request for high priority review
Needs Author Reply
Waiting for a reply from the original author
labels
Jun 22, 2022
After solving the raised issues, I'm ok with this PR being merged. |
thedroiddiv
force-pushed
the
AsyncTask_To_Coroutines
branch
from
June 22, 2022 07:32
0e29502
to
89c8054
Compare
ShridharGoel
changed the title
[GSoC] migrated AnkiStatsTaskHandler.createReviewSummaryStatistics() to susdend function
[GSoC] migrated AnkiStatsTaskHandler.createReviewSummaryStatistics() to suspend function
Jun 22, 2022
Once it gets merged, I can use the same ext function in #11628 and others as well. |
And also I thought of |
Looks good. |
ShridharGoel
approved these changes
Jun 22, 2022
lukstbit
approved these changes
Jun 22, 2022
github-actions
bot
removed
Review High Priority
Request for high priority review
Needs Author Reply
Waiting for a reply from the original author
labels
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #11556
Purpose / Description
AsyncTask to coroutines migration
Fixes
Fixes a part of #7108
How Has This Been Tested?
Unit tested and runs as expected on Realme 6i API 30 and Pixel 3a Emulator API 31
Affected part is the bottom 1 line statistics
before
after
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.
if
statements)