Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IDE lint in SchedTimingToday #11900

Closed
wants to merge 1 commit into from

Conversation

oyeraghib
Copy link
Contributor

Purpose / Description

fix IDE lint by renaming the functions names in SchedTimingToday.kt

Checklist

Please, go through these checks before submitting the PR.

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

rename functions names in SchedTimingToday.kt to fix IDE lint warnings
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency with Anki Desktop is more important than lint here. Propose to ignore the naming-based lint issues.

@oyeraghib
Copy link
Contributor Author

Consistency with Anki Desktop is more important than lint here. Propose to ignore the naming-based lint issues.

Okay, I understand! Thanks.

@oyeraghib oyeraghib closed this Jul 21, 2022
@david-allison
Copy link
Member

To note: I'd approve of a @SuppressLint here

@oyeraghib
Copy link
Contributor Author

@david-allison What would be the value for @SuppressLint here? Is it "VariableNamingDetector" ?

@david-allison
Copy link
Member

david-allison commented Jul 21, 2022

you can find out from the Quick fixes menu

Screenshot 2022-07-21 at 13 38 11

@oyeraghib
Copy link
Contributor Author

Something interesting happened. As I closed this PR, and then forced pushed, now it says The ____ branch was forced push or recreated. A new branch has been automatically created by GitHub from which I can make a new PR.

I went through this and realized many people have been through the same problem and GitHub officially hasn't come up with anything for this. Interesting!

@dae
Copy link
Contributor

dae commented Jul 22, 2022

An argument in favour of using more natural naming instead: #11582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants