Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NF: Use enum for flag everywhere possible #17434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NF: Use enum for flag everywhere possible #17434

wants to merge 1 commit into from
+147 −123

Commits on Nov 15, 2024

  1. NF: Use enum for flag everywhere possible 

    It should be added that there is some ambiguity for the value of the
flag. A flag could be either between 0 and 7, or an arbitrary int
whose first 3 digits are the displayed flags.

Actually, the only time a number greater than 7 is generated, it's
stored into the card's `flags` field, and never leave this object. So
it's okay to use `Flag` object everywhere else.
    @Arthur-Milchior
    Arthur-Milchior committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    894520c View commit details
    Browse the repository at this point in the history