Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Notice from Symfony HttpFoundation\Response #274

Closed
martincarlin87 opened this issue Jun 16, 2020 · 1 comment · Fixed by #282
Closed

Deprecated Notice from Symfony HttpFoundation\Response #274

martincarlin87 opened this issue Jun 16, 2020 · 1 comment · Fixed by #282

Comments

@martincarlin87
Copy link

Describe the bug
It looks like the Symfony dependencies have had a version bump and are now throwing a deprecated notice:

Since symfony/http-foundation 5.1: The "Symfony\Component\HttpFoundation\Response::create()" method is deprecated, use "new Symfony\Component\HttpFoundation\Response()" instead.

To Reproduce
Steps to reproduce the behavior:

  1. Run composer update
  2. Upload file

Expected behavior
No deprecation notice.

Screenshots

This is the diff in dependencies:

image

Additional context

I believe the issue is in https://github.com/ankitpokhrel/tus-php/blob/master/src/Response.php, but not sure if it is as easy as using new instead of ::create or if the class would need a little refactoring.

Hope it helps

@ankitpokhrel
Copy link
Owner

Thank you for reporting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants