Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [BUG] - icon can not overlap subscribe #875

Closed
1 task done
kapilG0 opened this issue Oct 7, 2024 · 21 comments · Fixed by #889
Closed
1 task done

🐞 [BUG] - icon can not overlap subscribe #875

kapilG0 opened this issue Oct 7, 2024 · 21 comments · Fixed by #889
Assignees
Labels
bug Something isn't working gssoc-ext hacktoberfest This is level for the hacktoberfest 2023 hacktoberfest-accepted This is level for the hacktoberfest 2023 level1

Comments

@kapilG0
Copy link

kapilG0 commented Oct 7, 2024

Description

Icons are overlapping on subscribe

Current behaviour

Screenshot_20241007_143111

Expected behaviour

Icon should not overlap

Reproduction steps

Go to home page and scroll below to configure that

Screenshots

DESCRIPTION

Logs

No response

Browsers

Chrome

OS

No response

Are you contributing for a program ?

Other

Code of Conduct

  • I have read and agree to the Contributing Guidelines of this project.
@kapilG0 kapilG0 added the bug Something isn't working label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Hello @kapilG0!
Thank you for raising this issue.
Please make sure to follow our Contributing Guidelines.
Don't forget to ⭐ our Grabtern-Frontend.

Our review team will carefully assess the issue and reach out to you soon!
We appreciate your patience!

@Sanchitbajaj02
Copy link
Collaborator

Hi @kapilG0
Can you explain how you are going to fix this issue as placing the support icon somewhere else will not look good?

@Sanchitbajaj02 Sanchitbajaj02 added level1 hacktoberfest This is level for the hacktoberfest 2023 hacktoberfest-accepted This is level for the hacktoberfest 2023 gssoc-ext labels Oct 8, 2024
@coderKrysio
Copy link
Contributor

hi @Sanchitbajaj02
as you can see the opacity of the chat button is low and its not perfectly aligned with scroll-to-top button
image

so here is the proposed solution:

  1. we increase the chat button opacity
  2. we align it with scroll-to-top button so that it doesnt look improper
  3. we change the color of the chat button to a darker shade from the website's proposed brand color palette

if you find these changes well and good, please assign me this issue

@Sanchitbajaj02
Copy link
Collaborator

Hi @coderKrysio
I like the idea of your proposal.

Since @kapilG0 didn't respond yet, I am assigning this issue to you

@coderKrysio
Copy link
Contributor

Thank you @Sanchitbajaj02
And can you add the level 2 label to this issue, it would be of great help

@Sanchitbajaj02
Copy link
Collaborator

Thank you @Sanchitbajaj02 And can you add the level 2 label to this issue, it would be of great help

I feel that the change is not major that it needs to be level 2. @anmode what's your opinion on this?

@coderKrysio
Copy link
Contributor

hey @Sanchitbajaj02
i have forked the repo and was installing the deps but got this issue
image

even after using the command npm run dev
I am unable to save any new changes and view it
the site is working fine after running this command, but it is not accepting any new changes and is making formatting error
can you help me with this

@Sanchitbajaj02
Copy link
Collaborator

Hi @coderKrysio
can you check and tell me what is your node and npm version installed? Because this isn't the major error, just the dependency issue which will gets fixed by using the latest version

@coderKrysio
Copy link
Contributor

coderKrysio commented Oct 10, 2024

@Sanchitbajaj02
image

Is the formatting issue caused by Eslint and Prettier being used together?
because even after dependency installation, I am unable to save any file properly

@coderKrysio
Copy link
Contributor

hey @Sanchitbajaj02
can you help me?
the formatting issue is still not resolved
I want to fix this error as soon as possible

@coderKrysio
Copy link
Contributor

hey @Sanchitbajaj02
please take a look at this error

Untitled.video.-.Made.with.Clipchamp.mp4

and let me know the measures I can take to fix it

@Sanchitbajaj02
Copy link
Collaborator

hey @Sanchitbajaj02 please take a look at this error

Untitled.video.-.Made.with.Clipchamp.mp4
and let me know the measures I can take to fix it

For this, you can open your VS Code settings and disable the format on save feature

@Sanchitbajaj02
Copy link
Collaborator

@Sanchitbajaj02 image

Is the formatting issue caused by Eslint and Prettier being used together? because even after dependency installation, I am unable to save any file properly

Yeah, seems like it, you can follow the above mentioned step to fix the issue

@coderKrysio
Copy link
Contributor

hey @Sanchitbajaj02 please take a look at this error
Untitled.video.-.Made.with.Clipchamp.mp4
and let me know the measures I can take to fix it

For this, you can open your VS Code settings and disable the format on save feature

I already did but still facing the same error

@Sanchitbajaj02
Copy link
Collaborator

Have you tried the auto save functionality? I think that does not do formatting

@coderKrysio
Copy link
Contributor

Have you tried the auto save functionality? I think that does not do formatting

tried that right now and still facing the same error

@Sanchitbajaj02
Copy link
Collaborator

Have you tried the auto save functionality? I think that does not do formatting

tried that right now and still facing the same error

is it possible that you can show me over discord?

@coderKrysio
Copy link
Contributor

Have you tried the auto save functionality? I think that does not do formatting

tried that right now and still facing the same error

is it possible that you can show me over discord?

yeah sure we can discuss this on video call

@Sanchitbajaj02
Copy link
Collaborator

Have you tried the auto save functionality? I think that does not do formatting

tried that right now and still facing the same error

is it possible that you can show me over discord?

yeah sure we can discuss this on video call

Please join the doubts voice channel on gssoc server and show me the issue

@coderKrysio
Copy link
Contributor

Have you tried the auto save functionality? I think that does not do formatting

tried that right now and still facing the same error

is it possible that you can show me over discord?

yeah sure we can discuss this on video call

Please join the doubts voice channel on gssoc server and show me the issue

I have opened one with the name anushree | contributor

@coderKrysio
Copy link
Contributor

Hey @Sanchitbajaj02
made the changes, need your confirmation before creating a pr
https://github.com/user-attachments/assets/d379e6b9-311c-46b8-8f65-e48e0a6618e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext hacktoberfest This is level for the hacktoberfest 2023 hacktoberfest-accepted This is level for the hacktoberfest 2023 level1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants