Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to reflect tinystatus .yaml file #13

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

CGenie
Copy link
Contributor

@CGenie CGenie commented Nov 29, 2024

The yaml in tinystsatus Python version contains groups etc. Moreover, it is assumed that .env file exists. To read it, I added godotenv. I fixed groups. I removed map[string]interface{} in favor of typed results. Smaller fixes as well (e.g. one should link to "history.html" to match the static files, as not everyone serves files using the built-in golang server).

Copy link

deepsource-io bot commented Nov 29, 2024

Here's the code health analysis summary for commits ee8b581..64eb72d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@annihilatorrrr
Copy link
Owner

Well @CGenie have you tested it out ?

@CGenie
Copy link
Contributor Author

CGenie commented Nov 29, 2024

Sample page with .env and config.yaml copied from tinystatus looks like this: https://frog02-30951.wykr.es/

I noticed it doesn't preserve group status, probably because of the go routine coupled with channels: order of incoming messages isn't predictable. But without groups it had the same problem.

@CGenie
Copy link
Contributor Author

CGenie commented Nov 29, 2024

OK I pushed a fix where I initialize the array of results first, then fill them in concurrently. This preserves the ordering of groups/results.

@annihilatorrrr annihilatorrrr added the enhancement New feature or request label Nov 29, 2024
@annihilatorrrr
Copy link
Owner

I hope everything is fine ?

@annihilatorrrr
Copy link
Owner

@CGenie remove cpu limitations: runtime.GOMAXPROCS(1), it's not needed for this type of programs.

@CGenie
Copy link
Contributor Author

CGenie commented Nov 29, 2024

OK done, I was testing things locally and comited that by accident.

@annihilatorrrr annihilatorrrr merged commit 06df5b0 into annihilatorrrr:main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants