-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to reflect tinystatus .yaml file #13
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Well @CGenie have you tested it out ? |
Sample page with I noticed it doesn't preserve group status, probably because of the go routine coupled with channels: order of incoming messages isn't predictable. But without groups it had the same problem. |
OK I pushed a fix where I initialize the array of results first, then fill them in concurrently. This preserves the ordering of groups/results. |
I hope everything is fine ? |
@CGenie remove cpu limitations: runtime.GOMAXPROCS(1), it's not needed for this type of programs. |
OK done, I was testing things locally and comited that by accident. |
The yaml in tinystsatus Python version contains groups etc. Moreover, it is assumed that
.env
file exists. To read it, I addedgodotenv
. I fixed groups. I removedmap[string]interface{}
in favor of typed results. Smaller fixes as well (e.g. one should link to"history.html"
to match the static files, as not everyone serves files using the built-in golang server).