Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final_check enforces msg to sign #75

Closed
grarco opened this issue Apr 11, 2024 · 0 comments · Fixed by #74
Closed

final_check enforces msg to sign #75

grarco opened this issue Apr 11, 2024 · 0 comments · Fixed by #74
Assignees
Labels
bug Something isn't working

Comments

@grarco
Copy link
Contributor

grarco commented Apr 11, 2024

Currently, final_check prepends the public key for signature verification to the sighash to construct the actual msg on which the signature should be verified. This is the correct logic for the single verifier but the batch one doesn't need this because it will reconstruct the correct message on its own. This lead to a signature verification error when using the batch verifier. We should change final_check to expect the correct msg and let the caller pass the correct value to support both verifications.

@grarco grarco added the bug Something isn't working label Apr 11, 2024
@grarco grarco mentioned this issue Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants