Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review ResultCode::WasmRuntimeError for batch errors #3199

Open
grarco opened this issue May 8, 2024 · 3 comments
Open

Review ResultCode::WasmRuntimeError for batch errors #3199

grarco opened this issue May 8, 2024 · 3 comments
Milestone
Nice to have and ...

Comments

@grarco
Copy link
Collaborator

grarco commented May 8, 2024

Based on #3103 (comment) we should review the use of this specific error code and maybe create a new one
@grarco grarco added this to the Phase 1: mainnet genesis milestone May 8, 2024
@grarco grarco mentioned this issue May 8, 2024
Merged
2 tasks
@sug0
Copy link
Collaborator

sug0 commented May 13, 2024

Depends on #3103

@cwgoes
Copy link
Collaborator

cwgoes commented Aug 22, 2024

@grarco Would this change be breaking or not?

@grarco
Copy link
Collaborator Author

grarco commented Aug 22, 2024

To me it looks like, as long as we don't shift the variants of the ResultCode enum but we just add new ones, this should be a non-breaking change

@cwgoes cwgoes added this to the Nice to have and non-breaking milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nice to have and non-breaking
Development

No branches or pull requests
3 participants
@sug0 @cwgoes @grarco