Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enjarify #38

Closed
anp opened this issue Oct 4, 2018 · 3 comments
Closed

add enjarify #38

anp opened this issue Oct 4, 2018 · 3 comments
Labels
benchmark needed new benchmarks we'd like to include

Comments

@anp
Copy link
Owner

anp commented Oct 4, 2018

https://github.com/Storyyeller/enjarify/tree/go/enjarify-rs

@anp anp added the benchmark needed new benchmarks we'd like to include label Oct 4, 2018
@anp anp changed the title new benchmark: enjarify add enjarify Oct 4, 2018
@jhwgh1968
Copy link

jhwgh1968 commented Apr 5, 2021

I looked into this a bit, and apparently there are not tests for the Rust rewrite. That's because it does not compile at all -- not even on Rust 1.36!

@anp, could you clarify what benchmarks you are referring to with this issue?

EDIT: It seems there is test code, it is just not in #[test] blocks. However, the inability to compile is still a problem. Are they still useful?

@jhwgh1968
Copy link

The compiler error, for the record:

   Compiling rustc-serialize v0.3.19
error[E0642]: patterns aren't allowed in methods without bodies
   --> /home/x/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/rustc-serialize-0.3.19/src/serialize.rs:147:45
    |
147 |                                             &f_name: &str,
    |                                             ^^^^^^^

@anp
Copy link
Owner Author

anp commented Apr 8, 2021

Alas! Thanks for looking into it. IIRC, this was originally referring to https://medium.com/@robertgrosse/parallelizing-enjarify-in-go-and-rust-21055d64af7e and some related posts about comparing the rewrites.

@anp anp closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark needed new benchmarks we'd like to include
Projects
None yet
Development

No branches or pull requests

2 participants