-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new module azure_rm_afdruleset to support Azure Frontdoor Standard and Premium #1592
Open
jartoo
wants to merge
4
commits into
ansible-collections:dev
Choose a base branch
from
jartoo:azure_rm_afdruleset
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+616
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request depends on azure-mgmt-cdn==13.1.0, which is captured in #1588 |
Fred-sun
added
new_module_pr
Add new modules
medium_priority
Medium priority
work in
In trying to solve, or in working with contributors
labels
Jun 13, 2024
Fred-sun
reviewed
Jun 26, 2024
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Fred-sun
added
ready_for_review
The PR has been modified and can be reviewed and merged
and removed
work in
In trying to solve, or in working with contributors
labels
Jun 28, 2024
@jartoo can you help resolve the file conflict. |
test failed:
|
@jartoo There is a conflict in this PR, please help solve the conflict, thank you! |
Fred-sun
removed
the
ready_for_review
The PR has been modified and can be reviewed and merged
label
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This module manages Frontdoor Rulesets for the Standard and Premium services. I propose building this as a separate module in lieu of complicating the azure_cdn_profile module so as to make the management of each of the elements easier. Azure Frontdoor is quite complex, so matching the modules with the Python SDK APIs seems to be the prudent design choice. I opted to include a Rulesets module, even though it appears Rules can create the missing Rulesets, simply for completeness.
Continues to work on #1041 This does not complete this issue, yet.
ISSUE TYPE
COMPONENT NAME
Module: azure_rm_afdruleset
ADDITIONAL INFORMATION
Provides the ability to manage Rulesets, per the Python SDK here: https://learn.microsoft.com/en-us/python/api/azure-mgmt-cdn/azure.mgmt.cdn.operations.rulesetsoperations?view=azure-python
Sanity and Integration tests: passed