Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new module azure_rm_afdruleset to support Azure Frontdoor Standard and Premium #1592

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

jartoo
Copy link
Contributor

@jartoo jartoo commented Jun 10, 2024

SUMMARY

This module manages Frontdoor Rulesets for the Standard and Premium services. I propose building this as a separate module in lieu of complicating the azure_cdn_profile module so as to make the management of each of the elements easier. Azure Frontdoor is quite complex, so matching the modules with the Python SDK APIs seems to be the prudent design choice. I opted to include a Rulesets module, even though it appears Rules can create the missing Rulesets, simply for completeness.

Continues to work on #1041 This does not complete this issue, yet.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

Module: azure_rm_afdruleset

ADDITIONAL INFORMATION

Provides the ability to manage Rulesets, per the Python SDK here: https://learn.microsoft.com/en-us/python/api/azure-mgmt-cdn/azure.mgmt.cdn.operations.rulesetsoperations?view=azure-python

Sanity and Integration tests: passed


@jartoo
Copy link
Contributor Author

jartoo commented Jun 10, 2024

This pull request depends on azure-mgmt-cdn==13.1.0, which is captured in #1588

@Fred-sun Fred-sun added new_module_pr Add new modules medium_priority Medium priority work in In trying to solve, or in working with contributors labels Jun 13, 2024
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun
Copy link
Collaborator

@xuzhang3 This PR relies on #1588, Please merge #1588 at first!Thanks!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 28, 2024
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Jul 1, 2024

@jartoo can you help resolve the file conflict.

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Jul 3, 2024

test failed:

fatal: [testhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": null,
            "cloud_environment": "AzureCloud",
            "disable_instance_discovery": false,
            "location": "Global",
            "log_mode": null,
            "log_path": null,
            "name": "prof-a06a880",
            "password": null,
            "profile": null,
            "resource_group": "ansibletest-44996de9-413f-499b-a0b0-2f35d37c5f27",
            "secret": null,
            "sku": "standard_azurefrontdoor",
            "state": "present",
            "subscription_id": null,
            "tags": null,
            "tenant": null,
            "thumbprint": null,
            "x509_certificate_path": null
        }
    },
    "msg": "value of sku must be one of: standard_verizon, premium_verizon, custom_verizon, standard_akamai, standard_chinacdn, standard_microsoft, got: standard_azurefrontdoor"
}

@Fred-sun
Copy link
Collaborator

Fred-sun commented Jul 8, 2024

@jartoo There is a conflict in this PR, please help solve the conflict, thank you!

@Fred-sun Fred-sun removed the ready_for_review The PR has been modified and can be reviewed and merged label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_module_pr Add new modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants