From 577fcd70c4b65f85bcaa53d021f81017eb3fbdb8 Mon Sep 17 00:00:00 2001 From: Alina Buzachis Date: Wed, 27 Oct 2021 17:57:20 +0200 Subject: [PATCH 1/2] Rename rds_snapshot to rds_instance_snapshot Signed-off-by: Alina Buzachis --- meta/runtime.yml | 7 +++++++ .../modules/{rds_snapshot.py => rds_instance_snapshot.py} | 6 +++--- .../rds_instance/roles/rds_instance/tasks/test_states.yml | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) rename plugins/modules/{rds_snapshot.py => rds_instance_snapshot.py} (99%) diff --git a/meta/runtime.yml b/meta/runtime.yml index bf736a3d34d..cdb0df6572f 100644 --- a/meta/runtime.yml +++ b/meta/runtime.yml @@ -520,3 +520,10 @@ plugin_routing: warning_text: >- route53_facts was renamed in Ansible 2.9 to route53_info. Please update your tasks. + rds_snapshot: + redirect: community.aws.rds_instance_snapshot + deprecation: + removal_version: 4.0.0 + warning_text: >- + rds_snapshot has been renamed to rds_instance_snapshot. + Please update your tasks. diff --git a/plugins/modules/rds_snapshot.py b/plugins/modules/rds_instance_snapshot.py similarity index 99% rename from plugins/modules/rds_snapshot.py rename to plugins/modules/rds_instance_snapshot.py index 0ca957c1b68..45915082739 100644 --- a/plugins/modules/rds_snapshot.py +++ b/plugins/modules/rds_instance_snapshot.py @@ -10,7 +10,7 @@ DOCUMENTATION = ''' --- -module: rds_snapshot +module: rds_instance_snapshot version_added: 1.0.0 short_description: manage Amazon RDS snapshots. description: @@ -66,12 +66,12 @@ EXAMPLES = ''' - name: Create snapshot - community.aws.rds_snapshot: + community.aws.rds_instance_snapshot: db_instance_identifier: new-database db_snapshot_identifier: new-database-snapshot - name: Delete snapshot - community.aws.rds_snapshot: + community.aws.rds_instance_snapshot: db_snapshot_identifier: new-database-snapshot state: absent ''' diff --git a/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_states.yml b/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_states.yml index 0321dc99d7c..dd13d55e164 100644 --- a/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_states.yml +++ b/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_states.yml @@ -144,7 +144,7 @@ always: - name: remove snapshot - rds_snapshot: + rds_instance_snapshot: db_snapshot_identifier: "{{ resource_prefix }}-test-snapshot" state: absent wait: false From 0b3b6e7d1695a743079f90a3543c65192d851a0f Mon Sep 17 00:00:00 2001 From: Alina Buzachis Date: Wed, 27 Oct 2021 18:05:35 +0200 Subject: [PATCH 2/2] Add changelog Signed-off-by: Alina Buzachis --- changelogs/fragments/783-rds_snapshot.yml | 3 +++ meta/runtime.yml | 1 + 2 files changed, 4 insertions(+) create mode 100644 changelogs/fragments/783-rds_snapshot.yml diff --git a/changelogs/fragments/783-rds_snapshot.yml b/changelogs/fragments/783-rds_snapshot.yml new file mode 100644 index 00000000000..f073aa1748a --- /dev/null +++ b/changelogs/fragments/783-rds_snapshot.yml @@ -0,0 +1,3 @@ +deprecated_features: + - rds_snapshot - the rds_snapshot module has been renamed to rds_instance_snapshot. + The usage of the module has not changed. The rds_snapshot alias will be removed in version 4.0.0 (https://github.com/ansible-collections/community.aws/pull/783). diff --git a/meta/runtime.yml b/meta/runtime.yml index cdb0df6572f..0aa95d868a2 100644 --- a/meta/runtime.yml +++ b/meta/runtime.yml @@ -190,6 +190,7 @@ action_groups: - rds_instance_info - rds_param_group - rds_snapshot + - rds_instance_snapshot - rds_snapshot_info - rds_subnet_group - rds_option_group