proxmox lxc - allow update of existing containers

[n0emis]

SUMMARY

Allow to update existing containers.

ISSUE TYPE

• Feature Idea

COMPONENT NAME

proxmox

ADDITIONAL INFORMATION

When managing lxc-containers on proxmox from ansible, it is currently not possible to update these containers, e.g. change the ip-address etc. This would be a really good addition, since it is currently needed to update this at multiple places: the playbook and proxmox itself.

[ansibullbot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

Files identified in the description:

• plugins/modules/cloud/misc/rhevm.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @Aversiste @timothyvandenbrande @joshainglis @karmab
click here for bot help

[tleguern]

This is actually harder than it looks as a careless update will destroy and recreate the network devices instead of updating them.

I am working on this problem for proxmox_kvm.

[ansibullbot]

Files identified in the description:

• plugins/modules/cloud/misc/proxmox

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @Ajpantuso @Thulium-Drake
click here for bot help

[ansibullbot]

Files identified in the description:

• plugins/modules/proxmox

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @UnderGreen
click here for bot help

[Skaronator]

This seems to be somewhat fixed by #7540. You can now provide a update: true flag, but sadly, it's not that simple. You cannot configure ostemplate in the same task, which means you have to split it up into 2 tasks, with the only difference being the ostemplate and update attribute.

I tried reducing duplicated code by using YAML Anchor like so:

- name: Create LXC Container (if missing) 
  community.general.proxmox: &container
    # proxmox api
    api_host: "{{ ansible_host }}"
    api_user: root@pam
    api_password: "{{ (admins | combine(users | default({}), recursive=true))['root']['password'] }}"
    node: "{{ ansible_hostname }}"
    # lxc config
    hostname: "{{ item.hostname }}"
    vmid: "{{ item.vmid }}"
    memory: "{{ item.memory }}"
    cpus: "{{ item.cpus }}"
    netif: "{{ item.netif | to_json }}"
    # static stuff
    swap: 0
    password: "{{ lxc_password }}"
    ostemplate: "{{ lxc_template_storage }}:{{ lxc_template_path }}/{{ item.template }}"
    pubkey: "{{ (admins | combine(users | default({}), recursive=true))['root']['sshpubkey'] }}"
  loop: "{{ lxc }}"

- name: Update LXC container
  community.general.proxmox:
    <<: *container
    state: "{{ item.state | default('started') }}"
    ostemplate: null
    update: true
  loop: "{{ lxc }}"

But this doesn't work since ostemplate is still present, and I can't get rid of it by setting ostemplate: null or leaving it empty (ostemplate: ).

It would be cool if the module ignored ostemplate altogether, and we can just use a single task with the limitation that you cannot update ostemplate.

[ansibullbot]

cc @krauthosting
click here for bot help