Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert 'default', 'choices', 'sample' to type; change booleans to 'true' and 'false' #19

Merged

Conversation

felixfontein
Copy link
Collaborator

@felixfontein
Copy link
Collaborator Author

The part on converting default, sample, and choices is necessary since there are quite a few modules and plugins which use strings like "yes" to provide default values (or choices, or samples), instead of proper boolean values. Without this change, there were quite a few cases where for a boolean parameter / return value the choices are true and false, but the default is yes, False, or something else. (Strings with False, True, false, or true in them are already showing up wrong at the moment.)

@felixfontein
Copy link
Collaborator Author

You can find generated docs at https://ansible.fontein.de/collections/

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfontein thanks for implementing the decision!

@felixfontein felixfontein merged commit d567311 into ansible-community:main Aug 15, 2022
@felixfontein felixfontein deleted the booleans-type-conversion branch August 15, 2022 11:46
@felixfontein
Copy link
Collaborator Author

@Andersson007 thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants