Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[podman] create.yml and destroy.yml hardcode ansible_async_dir #73

Closed
grcancelliere opened this issue Dec 4, 2022 · 0 comments · Fixed by #173
Closed

[podman] create.yml and destroy.yml hardcode ansible_async_dir #73

grcancelliere opened this issue Dec 4, 2022 · 0 comments · Fixed by #173
Labels

Comments

@grcancelliere
Copy link
Contributor

The PR ansible-community/molecule-podman#139 hardcodes ansible_async_dir to its default value $HOME/.ansible_async with a changed $HOME if the environment variable has a different value than the one in /etc/passwd. This means that any other method to change that variable, like defining it in group_vars, is ignored.

To avoid hardcoding variables this change can be applied by checking if the home from getent passwd and $HOME are different, and if so replacing the passwd home at the start of ansible_async_dir with the value from the $HOME environment variable.

I tried locally with a venv and it works, if you're interested I can write a PR for this.

@ssbarnea ssbarnea transferred this issue from ansible-community/molecule-podman Jan 8, 2023
@grcancelliere grcancelliere changed the title create.yml and destroy.yml hardcode ansible_async_dir [podman] create.yml and destroy.yml hardcode ansible_async_dir Jan 10, 2023
@apatard apatard added the podman label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants