You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RHEL-07-010491 task in fix-cat1.yml attempts to check/update /boot/grub2/grub.cfg, but this file does not exist on UEFI systems and the task fails. The old version of the role performed this task on /etc/grub.d/01_users which seems more proper since direct edits to grub.cfg are overwritten by grub2-mkconfig.
Dan,
Thank you for addressing this issue. We have an automated testing pipeline that does not like PR's from outside of it's own role. I changed the PR to go into staging and then will perform the PR to devel from there. Thanks again, I'll do the same with your other PR
Danbarr,
As an update I merged our changes into devel this morning. It was a bit out of sync with some other devel pushes so I had to get that sorted, but all is good. It will move into main with the May fixes push.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RHEL-07-010491 task in fix-cat1.yml attempts to check/update
/boot/grub2/grub.cfg, but this file does not exist on UEFI systems and the task fails. The old version of the role performed this task on/etc/grub.d/01_userswhich seems more proper since direct edits to grub.cfg are overwritten bygrub2-mkconfig.Signed-off-by: Dan Barr dan@dbarr.com