Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for build-requirements.txt #210

Open
pabelanger opened this issue Apr 26, 2021 · 3 comments
Open

Add support for build-requirements.txt #210

pabelanger opened this issue Apr 26, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@pabelanger
Copy link
Contributor

There is a need downstream, to include python build dependencies into the python-builder image, but not the final image. For this case, we've added support for build-requirements.txt file. But need to now allow for that in Dockerfiles generated by ansible-builder.

ansible/python-builder-image#35

@pabelanger
Copy link
Contributor Author

In this example, setuptools_scm is needed to compile a wheel, however isn't needed by the wheel installed into the final image.

@AlanCoding
Copy link
Member

What's the interface here? A file needs to be created, /tmp/src/build-requirements.txt.

Where does that go in the process? It looks like it would be:

  • User maintains another python requirements file for build requirements, separate from the existing file we support
  • That gets referenced somewhere in the definition file
  • Given those things, an ADD layer is added in the builder stage before the assemble script, and nothing else is needed

@mkjpryor
Copy link

I think these is also required for bindeps. For example, I might need gcc + Python header files in the builder image to build a wheel, but I don't want them in the final image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants