Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for PEP668 in pip invocations during build #604

Closed
nitzmahone opened this issue Sep 15, 2023 · 0 comments · Fixed by #627
Closed

Account for PEP668 in pip invocations during build #604

nitzmahone opened this issue Sep 15, 2023 · 0 comments · Fixed by #627
Assignees
Labels
enhancement New feature or request

Comments

@nitzmahone
Copy link
Member

Newer versions of pip implement PEP668 support, which will soon be enabled default (TL;DR, it will fail to install packages to system-managed Python environments, on which ansible-builder relies heavily).

Switching to virtual environments in EEs is not really an option for the short-medium term anyway; we need to continue to assume the ability to install any and all necessary packages in the system Python environment.

Luckily it should be an easy fix; we just need to ensure we're setting PIP_BREAK_SYSTEM_PACKAGES=1 in the environment for on all of builder's pip invocations; there shouldn't be any consequence to setting this for older pip versions, and it'll keep new ones functioning.

@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Sep 15, 2023
@Shrews Shrews added enhancement New feature or request and removed needs_triage New item that needs to be triaged labels Sep 18, 2023
@Shrews Shrews self-assigned this Oct 20, 2023
@Shrews Shrews moved this to In Progress in Builder 3.1 Oct 24, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Builder 3.1 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants