Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ade tree fails when collection contains a git repo as dependency #118

Closed
lask79 opened this issue Feb 25, 2024 · 1 comment
Closed

ade tree fails when collection contains a git repo as dependency #118

lask79 opened this issue Feb 25, 2024 · 1 comment
Labels
bug Something isn't working new

Comments

@lask79
Copy link

lask79 commented Feb 25, 2024

Issue

When I try to install my current collection that has a dependency to a git repository using:

ade install -e . --venv .venv

galaxy.yml

dependencies: {'git@github.com:organization/repo_name.git': 'devel'}

I get this error:

Traceback (most recent call last):
  File ".venv/bin/ade", line 8, in <module>
    sys.exit(main())/
  File ".venv/lib64/python3.10/site-packages/ansible_dev_environment/cli.py", line 177, in main
    cli.run()
  File ".venv/lib64/python3.10/site-packages/ansible_dev_environment/cli.py", line 158, in run
    subcommand.run()
  File ".venv/lib64/python3.10/site-packages/ansible_dev_environment/subcommands/treemaker.py", line 70, in run
    target[dep] = tree_dict[dep]
KeyError: 'git@github.com:organization/repo_name.git'

Analyzation
It looks ADE cannot use the git repo path as key. Is it possible to collect the real collection name out of the installed collection? the repo name is mostly not the same as the collection name.

@lask79 lask79 changed the title ade tree fails when collection contrains a git repo as dependency ade tree fails when collection contains a git repo as dependency Feb 26, 2024
@audgirka audgirka added bug Something isn't working new labels Feb 26, 2024
@audgirka
Copy link
Contributor

Duplicate of #117

@audgirka audgirka marked this as a duplicate of #117 Apr 24, 2024
@audgirka audgirka closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new
Projects
None yet
Development

No branches or pull requests

2 participants