Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable wrong-import-order this rule in pylint when making isort required #784

Closed
webknjaz opened this issue Jan 21, 2022 · 3 comments
Closed
Assignees
Labels
new New issues and PRs to triaged tests Related to testing and CI

Comments

@webknjaz
Copy link
Member

This issue has some of the explanation suggesting that pylint uses isort under the hood: pylint-dev/pylint#3817 (comment).

And this is what FAQ recommends explicitly too: https://pylint.pycqa.org/en/latest/faq.html#i-am-using-another-popular-linter-alongside-pylint-which-messages-should-i-disable-to-avoid-duplicates.

Originally posted by @webknjaz in #777 (comment) and https://github.com/ansible/ansible-navigator/pull/777/files#r789596349

@cidrblock
Copy link
Collaborator

unassigned self as I do not see an issue here until the sort order for pylint is violated, assigning @webknjaz to close or remediate

@cidrblock cidrblock assigned webknjaz and unassigned cidrblock Jan 29, 2022
@cidrblock
Copy link
Collaborator

The current configuration of pylint and isort do not conflict. If this is an issue in the future, it can be addressed with a new issue and PR.

@webknjaz
Copy link
Member Author

I think the main motivation was not the conflict resolution but rather performance optimization — less enabled rules usually mean that pylint may end up running a little bit faster. Since we usually raise the question of responsiveness, I imagine that this may be important. Also, having less duplicated output for the same violations from different tools would probably reduce cluttering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New issues and PRs to triaged tests Related to testing and CI
Projects
None yet
Development

No branches or pull requests

2 participants