Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dict provided inventory not read in containerized mode due to incorrect path set #1303

Closed
christophert opened this issue Sep 13, 2023 · 2 comments · Fixed by #1304
Closed
Labels
bug Something isn't working

Comments

@christophert
Copy link
Contributor

When inventory is provided via a Python dict, the output is not written to the correct path in the directory structure. This snippet:

kwargs['inventory'] = dump_artifact(json.dumps(obj), path, 'hosts.json')
writes the content to inventory/hosts.json while the runner looks for the inventory in inventory/hosts which is set (for containerized mode) in
self.inventory = '/runner/inventory/hosts'

@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Sep 13, 2023
@Shrews Shrews added bug Something isn't working and removed needs_triage New item that needs to be triaged labels Sep 19, 2023
@Shrews
Copy link
Contributor

Shrews commented Sep 19, 2023

I've been digging in to the inventory related code recently and can confirm this is definitely a thing that has been broken for a while.

@Shrews
Copy link
Contributor

Shrews commented Sep 19, 2023

Fixed by #1304

@Shrews Shrews closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants