-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the "Any" State from Notifications #4022
Comments
This issue is currently being worked on in PR #3982. |
verified |
@Spredzy did we actually test upgrade/migrations for these relationships on upgrade? I found a subtle bug while reviewing the PR that would have caused us to lose data on organization-wide any notifications on upgrade: I'd really like to see testing that involves setting up "any" relationships on:
And verifying that post-upgrade they all were converted to one success and one error. |
Load script:
Verify script:
|
ISSUE TYPE
Remove the
any
state fromunifiedjobtemplate_notification_templates
andorganization_notification_templates
.SUMMARY
The
any
state does not apply to all states, it only applies to one of two finished states (success
/error
). This can be confusing.Removing the
any
state will enable the user to define what they mean byany
, e.g., it's truly ALL of the states or it's only onjob finish
(the success/error/started states are additive, so they can select as many as they want).Note on backwards compatibility: After the related data migration has been applied, all of the
_any
relationships will automatically be turned into two relationships, one success and one error.The text was updated successfully, but these errors were encountered: