API allows non-option to be default in multiselect and multipechoice surveys

[IPvSean]

ISSUE TYPE

• Bug Report

SUMMARY

I am creating a very simple 4 node workflow. One of the Job Templates is auto-populated

    - name: CREATE RESTORE JOB TEMPLATE
      tower_job_template:
        name: "Network-Restore"
        job_type: "run"
        inventory: "Workshop Inventory"
        project: "Workshop Project"
        playbook: "network_restore.yml"
        credential: "Workshop Credential"
        survey_enabled: true
        survey_spec: "{{ lookup('template', '{{playbook_dir}}/templates/backup.j2') }}"
        tower_username: admin
        tower_password: ansible
        tower_host: "https://{{ansible_fqdn}}"
        validate_certs: no

here is the backup.j2 template referenced above for the survey_spec->
https://github.com/network-automation/tower_workshop/blob/master/templates/backup.j2

ENVIRONMENT

Tower 3.5.1

STEPS TO REPRODUCE

I am doing this exact exercise here: https://github.com/ansible/workshops/tree/devel/exercises/ansible_network/9-tower-workflow

EXPECTED RESULTS

Would force me to choose a prompt during the selection process for the Network-Restore Job Template

ACTUAL RESULTS

ADDITIONAL INFORMATION

more info coming

[chrismeyersfsu]

Steps to reproduce

• Create a JT w/ a survey w/ a multichoice (single select) field & a default answer.
• Go to that JT survey in the API & set the default answer to something not in the multichoice list

{
    "name": "",
    "description": "",
    "spec": [
        {
            "question_name": "This is a prompt",
            "question_description": "",
            "required": true,
            "type": "multiplechoice",
            "variable": "dfdsfd",
            "min": null,
            "max": null,
            "default": "foobar",
            "choices": "test\ntest2\ntest3"
        }
    ]
}

• Now create a workflow and use that JT and get the ERROR

[rebeccahhh]

Correct template link

[rebeccahhh]

When posting the API I seem to be getting the same issue as the UI has in #4192 and #4343
The /n in the given example is being ignored and when checking in the UI there is only 1 option, the string "test\ntest2\ntest3"
update: as stated in the issue linked above, this is intermittent and does not persist.

[rebeccahhh]

The UI does not allow anything other than existing options to be the default choice in a survey, but the API does.

API:

Posted in the API means the UI now shows:

Upon trying to do the same in the UI, it throws the appropriate error:

[kdelee]

Tested this out, you can no longer POST a survey spec w/ a default that is not an option, which was root cause of this bug.

Closing