Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML fixes #654

Merged
merged 4 commits into from
Nov 26, 2024
Merged

SAML fixes #654

merged 4 commits into from
Nov 26, 2024

Conversation

relrod
Copy link
Member

@relrod relrod commented Nov 21, 2024 •
edited by john-westcott-iv
Loading

This ensures that the firstname/lastname/email/etc attributes that are entered into the IdP fields are returned out of the assertion. If additional information is needed admins will have to either set GET_ALL_EXTRA_DATA to get it all or they can set EXTRA_DATA to get specific fields.

@john-westcott-iv john-westcott-iv force-pushed the saml-fixes branch 3 times, most recently from d7bcbaa to a421ac3 Compare November 22, 2024 17:14
@relrod @john-westcott-iv
Backend's ID_KEY might be None
b00db70 
Signed-off-by: Rick Elrod <rick@elrod.me>
@john-westcott-iv john-westcott-iv force-pushed the saml-fixes branch 4 times, most recently from f2b4e61 to c1d35eb Compare November 22, 2024 21:03
@relrod @john-westcott-iv
Store essential SAML attrs by default
9245485 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod @john-westcott-iv
Never fatal.
cf25706 
Signed-off-by: Rick Elrod <rick@elrod.me>
BrennanPaciorek
BrennanPaciorek reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@BrennanPaciorek BrennanPaciorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing some testing of the PR now, if I com back with nothing, I'll approve this.

ansible_base/authentication/authenticator_plugins/saml.py Outdated Show resolved Hide resolved
BrennanPaciorek
BrennanPaciorek approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@BrennanPaciorek BrennanPaciorek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that SAML auth no longer breaks via keycloak, and unit tests pass for me locally, LGTM.

@dmzoneill dmzoneill enabled auto-merge (rebase) November 26, 2024 14:00
@john-westcott-iv @BrennanPaciorek
Update ansible_base/authentication/authenticator_plugins/saml.py
272c9c6 
Co-authored-by: Brennan Paciorek <50780403+BrennanPaciorek@users.noreply.github.com>
@dmzoneill dmzoneill merged commit f9efc89 into ansible:devel Nov 26, 2024
10 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay-steurer jay-steurer jay-steurer approved these changes

@BrennanPaciorek BrennanPaciorek BrennanPaciorek approved these changes

@dmzoneill dmzoneill dmzoneill approved these changes

@john-westcott-iv john-westcott-iv Awaiting requested review from john-westcott-iv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@relrod @dmzoneill @john-westcott-iv @BrennanPaciorek @jay-steurer