-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apb push reports success even when the docker push has failed. #243
Comments
@jonnyfiveiq @tcunning closed #236 in favor of opening an issue specifically tracking this. |
@eriknelson When I tried looking at the docker logs I see the following error message
|
@mkanoor Do you mind printing the version of the APB tool you are using? Also, it appears you are logged in as "system:anonymous", can you ensure that To test this you can do: |
This might be a dupe because I think I made this issue previously but...
The docker client's push does not throw an Exception on a failed push. I am not sure if there is a better way to detect an error case, but you can open a pipe and read docker's output, parsing for an error. This is not ideal at all, so we should:
This is the specific call in question: https://github.com/ansibleplaybookbundle/ansible-playbook-bundle/blob/master/src/apb/engine.py#L968
The text was updated successfully, but these errors were encountered: