-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug located in ansys/doc-build@v8 #579
Comments
Transferring to ansys-sphinx-theme..? If not, we can move it back. Can you confirm whether the local build works? |
Just tried this locally, and it also fails, so I think this is a theme issue as opposed to a CI issue:
|
I am suspicious about something going on within this function: ansys-sphinx-theme/src/ansys_sphinx_theme/search/fuse_search.py Lines 191 to 229 in e91ee99
|
However, this is strange since other libraries have migrated to v1.2.1 and have no issues. Even when the |
This is certainly a strange issue. The PyGrantaJobQueue documentation builds file with the ^1.2 release, but bomanalytics and RecordLists fail. I can't think of any significant differences between these documentations. |
This issue occurred because of the grantami template used for the API reference, which we didn’t account for template parsing while creating json file. I’ve added the necessary changes in PR #586 and working in https://github.com/ansys/grantami-bomanalytics/actions/runs/11896275334/job/33148530429?pr=644 |
I'm glad to see this works with the bomanalytics package, thank you for identifying the issue! I did give this a go with our closed-source package as well though, and I now get the following error when building:
I'm guessing this function is related to the more powerful searching, which this closed-source package won't be using. Maybe this function can be wrapped in a broad exception handler that emits a warning if something goes wrong, and it's possible to just opt-out of running this function in the theme config? That way we'll be free to use this theme without worrying about these edge cases if we don't care about the more powerful cross-site searching. |
Great catch @Revathyvenugopal162 . |
Thank you @Andy-Grigg for testing it! I am now checking if the title is a list or not to avoid the error mentioned above. Could you please test it again with the same branch? |
@Revathyvenugopal162 Thanks! I just tested again, and I can confirm that commit bff0e89 works as expected. No errors during the docs build, and local search works. |
Thanks for confirming @Andy-Grigg |
🔍 Before submitting the issue
🐞 Description of the bug
Our CI fails when upgrading the sphinx theme to 1.2.0 with the following error:
📝 Steps to reproduce
https://github.com/ansys/grantami-bomanalytics/actions/runs/11619612949/job/32359611095?pr=640
Build the documentation for grantami-bomanalytics with Ansys sphinx theme 1.2.0
💻 Which operating system are you using?
Linux
📀 Which ANSYS version are you using?
n/a
🐍 Which Python version are you using?
3.10
📦 Installed packages
Installing dependencies from lock file
Package operations: 118 installs, 1 update, 0 removals
Installing the current project: ansys-grantami-bomanalytics (2.2.0dev0)
Run source .venv/bin/activate
Installing dependencies from lock file
Package operations: 47 installs, 0 updates, 0 removals
(CI run so cannot run pip freeze)
The text was updated successfully, but these errors were encountered: