Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

是否考虑给checkbox 顶层元素加个disable的类名 #13199

Closed
1 task
walker27 opened this issue Nov 20, 2018 · 4 comments
Closed
1 task

是否考虑给checkbox 顶层元素加个disable的类名 #13199

walker27 opened this issue Nov 20, 2018 · 4 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@walker27
Copy link

walker27 commented Nov 20, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.10.8

Environment

浏览器版本: Chrome 70

Reproduction link

Edit on CodeSandbox

Steps to reproduce

我司的UI期望对Checkbox进行一些样式调整,包括Checkbox的整体点击区域,现在我在调整样式后发现,disable情况下顶层元素没有disable样式名,导致内部元素的间隙无法出现禁用的手势

What is expected?

顶层元素增加disable的类名

What is actually happening?

顶层元素 没有disable类名


在顶层增加disable的类名有助于二次开发的样式调整

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Nov 20, 2018
@yutingzhao1991
Copy link
Contributor

确实,disable 的范围应该等同于点击的范围。给 https://github.com/react-component/select 这里来个 PR?

@walker27
Copy link
Author

walker27 commented Nov 20, 2018

确实,disable 的范围应该等同于点击的范围。给 https://github.com/react-component/select 这里来个 PR?

不是rc-checkbox吗

@walker27
Copy link
Author

我提了antd的checkbox的PR, 目前跟radio上的做法保持一致,还有一点,我发现radio上defaultChecked & disabled 的时候和 checked & disabled 的状态顶层的类名不一样(差了一个ant-radio-wrapper-checked)不知道这个有什么用意没有 @yutingzhao1991

@afc163 afc163 closed this as completed Nov 20, 2018
@afc163
Copy link
Member

afc163 commented Nov 20, 2018

@walker27 没啥用意,就是没加。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

3 participants