Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13413 - fix customize border-width problem in input group compact mode #13534

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

morenyang
Copy link
Contributor

Fix #13413

This issues caused by set border-right-width to 1px in input-group-comcapt last-child and input-group-comcapt select component.

please see the fix verison

image

image

image

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your pull request, thank you!

  • Make sure that you propose pull request to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a pull request to keep commit history clear.
  • Add some descriptions and refer relative issues for you pull request.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@netlify
Copy link

netlify bot commented Dec 10, 2018

Deploy preview for ant-design ready!

Built with commit 491560f

https://deploy-preview-13534--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #13534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13534   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         222      222           
  Lines        5915     5915           
  Branches     1691     1713   +22     
=======================================
  Hits         5491     5491           
+ Misses        416      414    -2     
- Partials        8       10    +2
Impacted Files Coverage Δ
components/transfer/index.tsx 89.93% <0%> (ø) ⬆️
components/time-picker/index.tsx 83.87% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2a42f...491560f. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #13534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13534   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         222      222           
  Lines        5915     5915           
  Branches     1691     1713   +22     
=======================================
  Hits         5491     5491           
+ Misses        416      414    -2     
- Partials        8       10    +2
Impacted Files Coverage Δ
components/transfer/index.tsx 89.93% <0%> (ø) ⬆️
components/time-picker/index.tsx 83.87% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2a42f...491560f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #13534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13534   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         222      222           
  Lines        5915     5915           
  Branches     1691     1713   +22     
=======================================
  Hits         5491     5491           
+ Misses        416      414    -2     
- Partials        8       10    +2
Impacted Files Coverage Δ
components/transfer/index.tsx 89.93% <0%> (ø) ⬆️
components/time-picker/index.tsx 83.87% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2a42f...491560f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #13534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13534   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         222      222           
  Lines        5915     5915           
  Branches     1691     1713   +22     
=======================================
  Hits         5491     5491           
+ Misses        416      414    -2     
- Partials        8       10    +2
Impacted Files Coverage Δ
components/transfer/index.tsx 89.93% <0%> (ø) ⬆️
components/time-picker/index.tsx 83.87% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2a42f...491560f. Read the comment docs.

@afc163 afc163 merged commit 6b94bd0 into ant-design:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input component with different border width on hover state when modify @border-width-base variable
2 participants