Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdvdfs-cli MD5 command doesn't work with Redump images #95

Closed
astarivi opened this issue Sep 13, 2024 · 1 comment · Fixed by #96
Closed

xdvdfs-cli MD5 command doesn't work with Redump images #95

astarivi opened this issue Sep 13, 2024 · 1 comment · Fixed by #96
Labels
bug Something isn't working xdvdfs-cli Relating to the xdvdfs command-line frontend

Comments

@astarivi
Copy link
Contributor

Redump images do not seem to work with the MD5 CLI command, the following error is printed out when trying to calculate the MD5:

error: Not an XDVDFS volume
@antangelo
Copy link
Owner

It looks like cmd_md5 is not using crate::img::open_image to open the source, which accounts for the volume offsets. Probably an oversight from doing the original refactor.

@antangelo antangelo added bug Something isn't working xdvdfs-cli Relating to the xdvdfs command-line frontend labels Sep 14, 2024
@astarivi astarivi mentioned this issue Sep 14, 2024
Merged
@antangelo antangelo linked a pull request Sep 15, 2024 that will close this issue
xdvdfs-cli Fix Redump (offsetted) image support at MD5 command #96
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working xdvdfs-cli Relating to the xdvdfs command-line frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xdvdfs-cli Fix Redump (offsetted) image support at MD5 command astarivi/xdvdfs
2 participants
@antangelo @astarivi