Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Report read-only API not enabled to caller #2148

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 27, 2024

Report read-only transactions execution not enabled on API node. Set read-only-threads > 0 to caller when /v1/chain/send_read_only_transaction is not supported because of no configured read-only-threads. Note this is handled correctly in 4.0.x.

Includes some misc fixes found while debugging this issue.

  • Log http errors before calling the callback cb, as cb may throw; e.g. cb not set.
  • Add missing } in a producer_plugin error log, so the error is reported correctly.
  • Add the response to the trx_provider error log when the http call fails.

@heifner heifner added the OCI Work exclusive to OCI team label Jan 27, 2024
@heifner heifner changed the base branch from main to release/5.0 January 27, 2024 16:51
@ericpassmore
Copy link
Contributor

ericpassmore commented Jan 29, 2024

Note:start
group: CLEANCODE
category: INTERNALS
summary: Now report read-only API not enabled to caller, when read-only-threads is not configured.
Note:end

@heifner heifner merged commit ffb2ec1 into release/5.0 Jan 29, 2024
26 checks passed
@heifner heifner deleted the report-read-only-error-5.0 branch January 29, 2024 13:08
@heifner heifner added this to the Leap v5.0.1 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants