[5.0] make read-only-threads defaults clearer in help text
#2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Feb 5, 2024
| @@ -1071,7 +1074,7 @@ void producer_plugin::set_program_options( | |||
| ("snapshots-dir", bpo::value<std::filesystem::path>()->default_value("snapshots"), | |||
| "the location of the snapshots directory (absolute path or relative to application data dir)") | |||
| ("read-only-threads", bpo::value<uint32_t>(), | |||
| "Number of worker threads in read-only execution thread pool. Max 8.") | |||
| ("Number of worker threads in read-only execution thread pool. Defaults to 0 if configured as producer, otherwise defaults to "s + std::to_string(producer_plugin_impl::_ro_default_threads_nonproducer) + ". Max "s + std::to_string(producer_plugin_impl::_ro_max_threads_allowed) + "."s).c_str()) | |||
There was a problem hiding this comment.
.c_str()
option_description makes a copy of the char* passed in so this should be okay; not sure what a better pattern may be
There was a problem hiding this comment.
If option_description did not makes a copy of the char* passed, you could return s.c_str(), s being a static std::string declared in a lambda called immediately, but probably fine as is.
heifner
approved these changes
Feb 5, 2024
greg7mdp
approved these changes
Feb 5, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2103