[5.0] Fix issue #2330 by limiting the vector size that can be reserve'd #2405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2330.
The deserialization of arrays involves reading a size, and then the array elements which are
emplace
'd back into astd::vector
. For normal vectors, since we know the size in advance, it is beneficial to callstd::vector::reserve()
to prevent quadratic reallocations of the vector's buffer as the values are read. Still, limit the size that can be reserved to1024
fc::variant
values, or 16KB sincesizeof(fc::variant) == 16
).