refactor(stream): make MessageStream wrap Stream directly
#805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertCraigie
changed the title
MessageStream wrap Stream more directlyMessageStream wrap Stream directly
RobertCraigie
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
Thanks!
This PR not only fixes the issue for us but also seems cleaner and more logical within this codebase - why recreate the Stream with the same arguments? It seems like a relic from when MessageStream was a subclass of Stream and passing the same arguments to init made more sense.
yup spot on
note that this is technically a breaking change as MessageStream.__init__ is public API but I'd be surprised if anyone is relying on it
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to address pydantic/logfire#672. We patch the client
_requestmethods to replace thestream_clsargument with a wrapper class that logs streamed values. But that wrapper gets lost byMessageStreamandMessageStreamManager. This PR not only fixes the issue for us but also seems cleaner and more logical within this codebase - why recreate theStreamwith the same arguments? It seems like a relic from whenMessageStreamwas a subclass ofStreamand passing the same arguments to__init__made more sense.