"cluster nodes" serialization format change / documentation

[mgravell]

Testing against 4.0.1 configured as a cluster using the basic 6-node config in the tutorial; example output of cluster nodes:

127.0.0.1:7000> cluster nodes
470b4028aba5f2cde905a2cb327e15390c86c45c 127.0.0.1:7003@17003 slave aaf9b548a6e997c37f8e2a3d7fc19aceef160b30 0 1501583788418 4 connected
1020c8eee6a0d195bdf48f89b1865e74411b008a 127.0.0.1:7005@17005 slave 4850b704c1a6464d47de632ab675e6a9150b57f0 0 1501583786511 6 connected
aaf9b548a6e997c37f8e2a3d7fc19aceef160b30 127.0.0.1:7000@17000 myself,master - 0 1501583786000 1 connected 0-5460
4850b704c1a6464d47de632ab675e6a9150b57f0 127.0.0.1:7002@17002 master - 0 1501583787916 3 connected 10923-16383
caab5c2dcbb05026d1be58be85ff7052f756e036 127.0.0.1:7001@17001 master - 0 1501583786511 2 connected 5461-10922
fe35d5d303821f19d01756c7886e66841de74237 127.0.0.1:7004@17004 slave caab5c2dcbb05026d1be58be85ff7052f756e036 0 1501583788000 5 connected

This does not match the documentation - see the 127.0.0.1:7003@17003 for example. What was <ip:port> is now <ip:port@something>

Request clarification.

Side note: yes, I should move to cluster slots, but: cluster slots didn't exist when I wrote this part of the library code :)

Environment in case this matters: WSL (Windows 10) running Ubuntu 16.04.2 LTS

[antirez]

Sorry @mgravell! I totally forgot to mention this in the release note, section of backward incompatible changes. Unfortunately compatibility with Docker / NAT-ted environments forced changes in the Cluster bus binary protocol, and also needed the ability to have arbitrary bus TCP port, it is no longer mandatory to be at +10000 offset. So now also the cluster bus port is announced after the "@". There are no other changes AFAIK.

[antirez]

In practical terms this means that you can ignore the @... part.

[mgravell]

That's what I assumed; I've pushed an updated build of my client lib, but note that this could also adversely affect other clients that use cluster nodes rather than cluster slots

[antirez]

Thanks, I'll send a note via ML / Twitter and update the 4.0 changelog accordingly.