Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange Month column in a test dataset #142

Closed
antoinecarme opened this issue Jul 23, 2020 · 4 comments
Closed

Strange Month column in a test dataset #142

antoinecarme opened this issue Jul 23, 2020 · 4 comments

Comments

@antoinecarme
Copy link
Owner

the column 'Month' seems wrong in this log

https://github.com/antoinecarme/pyaf/blob/master/tests/references/exog_test_ozone_exogenous.log

INFO:pyaf.std:START_TRAINING 'Ozone'
      Date  Month  Exog2 Exog3 Exog4  Ozone       Time
0  1955-01   1955      1    AQ   P_R    2.7 1955-01-01
1  1955-02   1955      2    AR   P_R    2.0 1955-02-01
2  1955-03   1955      3    AS   P_S    3.6 1955-03-01
3  1955-04   1955      4    AT   P_U    5.0 1955-04-01
4  1955-05   1955      5    AU   P_V    6.5 1955-05-01
INFO:pyaf.std:END_TRAINING_TIME_IN_SECONDS 'Ozone' 18.12391185760498
INFO:pyaf.std:TIME_DETAIL TimeVariable='Time' TimeMin=1955-01-01T00:00:00.000000 TimeMax=1967-09-01T00:00:00.000000 TimeDelta=<DateOffset: months=1> Horizon=12
INFO:pyaf.std:SIGNAL_DETAIL_ORIG SignalVariable='Ozone' Length=204  Min=1.2 Max=8.7  Mean=3.8357843137254903 StdDev=1.4915592159401185
INFO:pyaf.std:SIGNAL_DETAIL_TRANSFORMED TransformedSignalVariable='_Ozone' Min=1.2 Max=8.7  Mean=3.8357843137254903 StdDev=1.4915592159401185

Need to see where this error comes from,. an original CSV file ? a computation ? analyze the overall impact on the tests.

@antoinecarme
Copy link
Owner Author

This log is obtained by executing the following test :

https://github.com/antoinecarme/pyaf/blob/master/tests/exog/test_ozone_exogenous.py

Which builds a model on a file obtained by calling :

def load_ozone_exogenous() :

@antoinecarme
Copy link
Owner Author

load_ozone_exogenous tries to load a file :

trainfile = "https://raw.githubusercontent.com/antoinecarme/pyaf/master/data/ozone-la-exogenous.csv"

image

@antoinecarme
Copy link
Owner Author

antoinecarme commented Jul 23, 2020

Conclusion : The 'Month' column is wrong in the original dataset CSV file.

  1. Who created this file ? script/notebook ?
  2. Is it widely used (impact) in the tests ? Was it used as a basis to create other CSV files ?
  3. Is the 'Month' column used in the models ?

@antoinecarme antoinecarme changed the title strange Month column in a test dataset Strange Month column in a test dataset Jul 23, 2020
@antoinecarme antoinecarme self-assigned this Jul 23, 2020
antoinecarme added a commit that referenced this issue Jun 20, 2021
Removed extra 'Month' column
No impact on training process
Impacts some exogenous data tests
Updated the dataset
antoinecarme added a commit that referenced this issue Jun 20, 2021
Removed extra 'Month' column
No impact on training process
Impacts some exogenous data tests
Updated the dataset
@antoinecarme
Copy link
Owner Author

Fixed the dataset and its related tests.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant